Skip to content

Fix/go version docs#118

Merged
mason-sharp merged 2 commits intomainfrom
fix/go-version-docs
Apr 21, 2026
Merged

Fix/go version docs#118
mason-sharp merged 2 commits intomainfrom
fix/go-version-docs

Conversation

@rasifr
Copy link
Copy Markdown
Member

@rasifr rasifr commented Apr 21, 2026

  • sync Go version requirement to 1.26, drop stale CGO note
  • fix config key names, add missing CDC key, update install version

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026 •
edited
Loading

Warning

Rate limit exceeded

@rasifr has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 53 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 52 minutes and 53 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2140c767-bc4e-46a6-a633-f2a69d3dd32d

📥 Commits

Reviewing files that changed from the base of the PR and between b73f7bf and 61d6991.

📒 Files selected for processing (3)
  • README.md
  • docs/configuration.md
  • docs/install.md
📝 Walkthrough

Walkthrough

The pull request updates Go version prerequisites from 1.18/1.20 to 1.26 across build documentation, introduces a new CDC metadata flush configuration property, renames TLS certificate authentication configuration keys, and enhances error tracking and control flow in the table diff task implementation.

Changes

Cohort / File(s) Summary
Build & Installation Requirements
README.md, docs/install.md		 Updated Go version prerequisites from 1.18/1.20 to 1.26 minimum; updated version examples from v1.5.3 to v1.9.0; removed CGO and system SQLite dependencies.
Configuration Documentation
docs/configuration.md		 Added mtree → cdc → cdc_metadata_flush_seconds configuration property (default: 10); renamed cert_auth keys from user_cert_file/user_key_file to ace_user_cert_file/ace_user_key_file.
Diff Task Implementation
internal/consistency/diff/table_diff.go		 Added shared error-state tracking via atomic bool; refactored worker control flow to use unified shouldStop() check across hashing and diff goroutines; improved error handling to terminate recursion early on errors.

Poem

🐰 From twenty-six, our Go now flies,
New configs dance before our eyes,
Error tracking brings us grace,
SQLite pure without a trace,
Each change hops forth with perfect pace! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and uses generic terminology that doesn't clearly convey the specific changes made in the PR. Consider using a more descriptive title such as 'Update Go version requirement to 1.26 and fix documentation' or 'Sync Go version docs, fix config keys, and add CDC metadata setting'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description directly addresses the main changes including Go version sync, config key corrections, CDC key addition, and version updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/go-version-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 21, 2026 •
edited
Loading

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

rasifr and others added 2 commits April 21, 2026 16:32
@rasifr @claude
docs: sync Go version requirement to 1.26, drop stale CGO note
f77cb98 
README and install docs referenced Go 1.18/1.20; go.mod requires 1.26.
Also removed the outdated CGO/libsqlite3 requirement — the project now
uses modernc.org/sqlite (pure Go, no CGO needed).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rasifr @claude
docs: fix config key names, add missing CDC key, update install version
61d6991 
- Fix cert_auth key names: user_cert_file/user_key_file →
  ace_user_cert_file/ace_user_key_file to match YAML struct tags
- Add missing mtree.cdc.cdc_metadata_flush_seconds to config table
- Update hardcoded v1.5.3 → v1.9.0 with a note to keep it current

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rasifr rasifr force-pushed the fix/go-version-docs branch from b73f7bf to 61d6991 Compare April 21, 2026 11:37
@mason-sharp mason-sharp merged commit 0157cc8 into main Apr 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mason-sharp mason-sharp mason-sharp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rasifr @mason-sharp